search

kentcdodds / kcd-discord-bot-v1

The bot for the KCD discord community
https://kcd.im/discord
MIT License
122 stars 41 forks source link

Meetups: Add YouTube and WebinarGeek domains for skipping a voice channel #83

Closed bouwe77 closed 3 years ago

bouwe77 commented 3 years ago

What:

When starting a meetup, a Discord voice channel is created automatically. However, if you include a link to Zoom, or Twitch, in your meetup description, no voice channel is created, but instead the link is displayed for others to click to join the meetup there.

I've added domains for some more platforms where a link should be displayed: WebinarGeek.com and YouTube.

Why:

Although not many meetups are being organized, having some other popular platforms that support this nice feature can be convenient. And WebinarGeek? I'll probably be the only one using it, but then at least for me it's convenient. 😊

How:

I've added the following domains to the regex that determines whether a voice channel or link should be used:

I've also expanded the tests for this functionality with an .each so every supported domain is tested now.

Checklist:

codecov[bot] commented 3 years ago

Codecov Report

Merging #83 (c0d258e) into main (abb4284) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   66.02%   66.02%           
=======================================
  Files          44       44           
  Lines        1760     1760           
  Branches      487      501   +14     
=======================================
  Hits         1162     1162           
  Misses        597      597           
  Partials        1        1
Impacted Files Coverage Δ
src/commands/command-fns/meetup.ts 88.88% <ø> (ø)
src/meetup/utils.ts 90.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update abb4284...c0d258e. Read the comment docs.

bouwe77 commented 3 years ago

Please let me know if I also should update the meetups page on your site, because it only mentions Zoom now.