kentcdodds / kcd-scripts

CLI toolbox for common scripts for my projects
http://npm.im/kcd-scripts
MIT License
885 stars 207 forks source link

feat: update dependencies #228

Closed MichaelDeBoey closed 2 years ago

MichaelDeBoey commented 2 years ago

I also replaced rollup-plugin-node-builtins& rollup-plugin-node-globals with rollup-plugin-polyfill-node as that's what the @rollup team recommends & the @babel team did as well in https://github.com/babel/babel/pull/11098.


BREAKING CHANGE: Use Jest v28

codecov[bot] commented 2 years ago

Codecov Report

Merging #228 (da7e917) into main (01550fe) will not change coverage. The diff coverage is 87.50%.

@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   63.33%   63.33%           
=======================================
  Files          21       21           
  Lines         600      600           
  Branches      228      227    -1     
=======================================
  Hits          380      380           
  Misses        179      179           
  Partials       41       41           
Impacted Files Coverage Δ
src/config/jest.config.js 92.30% <ø> (ø)
src/config/prettierrc.js 100.00% <ø> (ø)
src/scripts/build/rollup.js 0.00% <0.00%> (ø)
src/config/rollup.config.js 71.11% <100.00%> (-0.63%) :arrow_down:
src/run-script.js 97.87% <100.00%> (+0.04%) :arrow_up:
src/utils.js 89.56% <100.00%> (+0.09%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

MichaelDeBoey commented 2 years ago

@kentcdodds Seems like snapshots are only failing on Windows for some reason 🤔

kentcdodds commented 2 years ago

Hmmm... I'm not sure. Maybe windows is adding extra lines to the output for some reason?

MichaelDeBoey commented 2 years ago

Yeah don't know either how we could fix this tbh 🤔

nickserv commented 2 years ago

Would this be safe to merge (after resolving conflicts)? I'm running into a configuration issue for the Recorder Extension's e2e test suite because of the old Jest version, and it's blocking my next major release. Let me know if I can help with anything.

kentcdodds commented 2 years ago

Once we resolve conflicts and figure out what to do about the failing build then I'm happy to merge.

nickserv commented 2 years ago

The build seems to be failing because the new version of glob requires using POSIX paths, but we're using native paths (so Windows is not using POSIX paths). I'm trying to fix this internally, but it would technically still be a breaking change, as you'd have to use POSIX --ignore patterns on Windows.

nickserv commented 2 years ago

I think I fixed it. @MichaelDeBoey can you please review https://github.com/MichaelDeBoey/kcd-scripts/pull/66 when you can? It's set to merge into this PR.

kentcdodds commented 2 years ago

Uh oh. Looks like the build is actually failing so we won't get a release if I merge this 😬

kentcdodds commented 2 years ago

🤦‍♂️ just read the thread and now I understand what's going on 😅 Thanks for your work @nickmccurdy! Excited to get this merged 👍

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 12.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: