search

kentcdodds / match-sorter

Simple, expected, and deterministic best-match sorting of an array in JavaScript
https://npm.im/match-sorter
MIT License
3.73k stars 129 forks source link

fix: still sort when search value is absent #101

Closed RebeccaStevens closed 4 years ago

RebeccaStevens commented 4 years ago

fix #100

What: Sort when search value is absent.

Why: Consistency.

How: Don't early escape if search value is absent.

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #101 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #101   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          156       155    -1     
  Branches        38        37    -1     
=========================================
- Hits           156       155    -1
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cad3220...4c072a0. Read the comment docs.

kentcdodds commented 4 years ago

:tada: This PR is included in version 4.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: