search

kentcdodds / match-sorter

Simple, expected, and deterministic best-match sorting of an array in JavaScript
https://npm.im/match-sorter
MIT License
3.73k stars 129 forks source link

feat: add sort items alphabetically test case #106

Closed mrceperka closed 4 years ago

mrceperka commented 4 years ago

What: Extra test case for alphabetical sorting.

Why: Because alphabetical sorting is expected and desired behavior.

How: TODO

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #106 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          155       157    +2     
  Branches        37        39    +2     
=========================================
+ Hits           155       157    +2
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1899d4c...7cc0091. Read the comment docs.

kentcdodds commented 4 years ago

Would you be willing to add your suggested change to fix this?

mrceperka commented 4 years ago

Yeah, will do asap.

kentcdodds commented 4 years ago

I've thought about a different breaking change I want to make. I don't like the CASE_RANKINGS feature at all and that's what's causing these issues. So I'll remove that feature (and show a workaround) and that'll fix this. Thanks!

kentcdodds commented 4 years ago

:tada: This issue has been resolved in version 5.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

mrceperka commented 4 years ago

@kentcdodds Cool, that's even better :)