Don't allow simple match to meet acronym threshold

kentcdodds / match-sorter

Simple, expected, and deterministic best-match sorting of an array in JavaScript

https://npm.im/match-sorter

MIT License

3.73k stars 129 forks source link

Closed sdbrannum closed 5 years ago

sdbrannum commented 5 years ago

What:

Added test case for acronym threshold.

Why:

Currently, the base simple match threshold is meeting the standard of the acronym threshold in certain instances.

How:

Checklist:

kentcdodds commented 5 years ago

Ah yes, this is definitely a bug. Would you be willing to add a commit for the fix? Thanks!

sdbrannum commented 5 years ago

@kentcdodds I'd love to. It may take a few days as I try to figure out the "correct" way to weight simple matches comparatively on a scale.

kentcdodds commented 5 years ago

Thank you!

kentcdodds commented 5 years ago

:tada: This PR is included in version 3.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

kentcdodds commented 5 years ago

@all-contributors please add @sdbrannum for code and tests

allcontributors[bot] commented 5 years ago

@kentcdodds

I've put up a pull request to add @sdbrannum! :tada: