kentcdodds / mdx-bundler

🦤 Give me MDX/TSX strings and I'll give you back a component you can render. Supports imports!
MIT License
1.78k stars 75 forks source link

feat: support esbuild@0.15.x #188

Closed hughrawlinson closed 1 year ago

hughrawlinson commented 2 years ago

What: Add esbuild@0.15.x to the list of peer dependencies.

Why: At the moment, npm install will fail when the version of esbuild included in the project is on the latest minor version.

How:

Checklist:

I don't know how to test this. I haven't seen anything in the changelog that would indicate to me it wouldn't work, but then I don't know the internals. The changelog refers to backwards incompatible changes, but they are to do with moving to an internal implementation of Yarn's PlugnPlay algorithm. Any advice would be greatly appreciated.

leon commented 2 years ago

Any news on this?

magoz commented 2 years ago

Waiting for this to be merged too. Any updates?

kentcdodds commented 1 year ago

Sorry for the radio silence. This has been resolved.

priyang12 commented 1 year ago

hi i thought this issue was resolved but when I installed latest version of the mdx-bundler I am still getting

      "peerDependencies": {
        "esbuild": "0.11.x || 0.12.x || 0.13.x || 0.14.x"
      }
  in package-lock.json file

Is there any other alternative like overriding it?

kentcdodds commented 1 year ago

Looks like the release failed to go through because the build is busted. I'm afraid I don't have time to fix it myself, but I'd accept a PR.

priyang12 commented 1 year ago

i could make one but I don't know what to change since "esbuild": "0.*"is set in package.json. is the build pipeline failed is the reason for an issue not being fixed?

kentcdodds commented 1 year ago

The build pipeline failure is the reason it's not released.

priyang12 commented 1 year ago

ok, I look into it if i can solve it. thanks for your reply.

priyang12 commented 1 year ago

hey @kentcdodds i have made a PR 198

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 9.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: