kentcdodds / nps-utils

Utilities for http://npm.im/nps (npm-package-scripts)
https://doclets.io/kentcdodds/nps-utils/master
MIT License
101 stars 23 forks source link

feat(ncp): add `ncp` which uses `ncp` #21

Closed indfnzo closed 7 years ago

indfnzo commented 7 years ago

Adds an alternative util to copy (cpy-cli) using ncp to allow recursive copying of directories.

closes #20

indfnzo commented 7 years ago

Seems like I screwed something up with the testing environment, HAHA. Should I have not modified the snapshot?

kentcdodds commented 7 years ago

Hmmm... It looks like you're on a windows machine. We need to normalize the paths for our snapshots. I think we could do that in this function. Just want to make sure the slashes in the path are the same across platforms. I'm not totally sure of the best way to do that. Would you like to look into it? Thanks!

indfnzo commented 7 years ago

Sure, I just have some things to settle right now. I'll try to get to this some time this week.

kentcdodds commented 7 years ago

Hmm... The build is breaking due to eslint errors. Could give those a look? Thanks!

codecov[bot] commented 7 years ago

Codecov Report

Merging #21 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          61     62    +1     
=====================================
+ Hits           61     62    +1
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6753ad5...a5c0980. Read the comment docs.

indfnzo commented 7 years ago

Just now I realized I could lint locally with nps lint, HAHA. Anyway, everything seems in place.

indfnzo commented 7 years ago

:)

kentcdodds commented 7 years ago

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

indfnzo commented 7 years ago

Great, thanks!

I missed the part about adding myself as a contributor manually, so it's actually not part of this pull request. Other than that, I believe I was able to follow all the rules.

kentcdodds commented 7 years ago

Feel free to open another pull request to add yourself 👍