search

kentcdodds / react-workshop-app

An abstraction for all my React workshops
https://kentcdodds.com/workshops
MIT License
149 stars 37 forks source link

Scroll bar on examples is always displayed on Chrome for Windows #12

Closed gustavobmichel closed 4 years ago

gustavobmichel commented 4 years ago

What happened: epic-react-bug

Problem description: When opening the workshop exercises, a scrollbar is always displayed on the exercise page and when clicking on Extra Credit, even when the scrollbar is not needed. I am using Chrome 85 on Windows 10.

Suggested solution: Add overflow-y: auto for the exercise Sandbox and overflow-x: auto for ExtraCreditTabs. I do not have a MacOS so not sure if that would not give a different outcome for Macs.

kentcdodds commented 4 years ago

Thanks for suggesting this! I'm guessing your suggestion works for windows, so I'll give it a shot on my mac and if it works I'll go for it :)

kentcdodds commented 4 years ago

That worked! Thanks :)

kentcdodds commented 4 years ago

@all-contributors please add @gustavobmichel for bugs

allcontributors[bot] commented 4 years ago

@kentcdodds

I've put up a pull request to add @gustavobmichel! :tada:

kentcdodds commented 4 years ago

:tada: This issue has been resolved in version 2.16.9 :tada:

The release is available on:

Your semantic-release bot :package::rocket: