kentcdodds / react-workshop-app

An abstraction for all my React workshops
https://kentcdodds.com/workshops
MIT License
149 stars 37 forks source link

Make test (more) platform independent #18 #21

Closed Snaptags closed 4 years ago

Snaptags commented 4 years ago

What: codegen snapshot test fails on Windows #18

Why: The test should run on "all" platforms and report the same results doing so.

How: debugging the test, normalizing path formatting

Checklist:

Using split/join to replace the path by PROJECT_ROOT is quite nice, have to remember that.

codecov[bot] commented 4 years ago

Codecov Report

Merging #21 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files           5        5           
  Lines         135      135           
  Branches       30       30           
=======================================
  Hits          126      126           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2c6e0c...0548ebf. Read the comment docs.

kentcdodds commented 4 years ago

@all-contributors please add @Snaptags for tests

allcontributors[bot] commented 4 years ago

@kentcdodds

I've put up a pull request to add @Snaptags! :tada:

kentcdodds commented 4 years ago

:tada: This PR is included in version 2.16.11 :tada:

The release is available on:

Your semantic-release bot :package::rocket: