Snaptags commented 4 years ago

What: Make sure not to break valid paths on unix-based platforms

Why: Using path.sep is a more common way to solve cross-platform related problems. This should be used instead of hard coded backslashes.

How: Tested using Windows PowerShell and Ubuntu Zsh

Checklist:

[ ] Documentation N/A
[ ] Tests N/A
[x] Ready to be merged

codecov[bot] commented 4 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files           5        5           
  Lines         135      135           
  Branches       30       30           
=======================================
  Hits          126      126           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2c6e0c...10ad646. Read the comment docs.

kentcdodds commented 4 years ago

:tada: This PR is included in version 2.16.11 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

kentcdodds / react-workshop-app

chore: don't break valid linux paths #22

Codecov Report