kentcdodds / react-workshop-app

An abstraction for all my React workshops

https://kentcdodds.com/workshops

MIT License

149 stars 37 forks source link

Multiple exercise files #26

Closed Aprillion closed 4 years ago

Aprillion commented 4 years ago

Discussed in https://discord.com/channels/715220730605731931/759594515668926514/763386789279957022

Not sure if suitable for existing workshops in EpicReact.dev, because the videos would not match exactly how it would look on localhost :(

I had to merge the "Final" and "Extra Credits" tabs to keep the code (if conditions) from exploding...
no hot reload for new files

But could be a good start of next major version, if someone can figure out the hot reload of new files ¯\_(ツ)_/¯

multiple exercises

codecov[bot] commented 4 years ago

Codecov Report

Merging #26 into master will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   93.33%   93.38%   +0.04%     
==========================================
  Files           5        5              
  Lines         135      136       +1     
  Branches       30       31       +1     
==========================================
+ Hits          126      127       +1     
  Misses          9        9

Impacted Files	Coverage Δ
src/codegen.js	`100.00% <ø> (ø)`
src/load-files.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b0d80c...d3ff4ad. Read the comment docs.

kentcdodds commented 4 years ago

It's impossible to get new files to be hot reloaded. A server restart will be required. I do like this UI though. Let me give the code a quick review. Thanks!

Aprillion commented 4 years ago

Looks like the build is failing only on Node 10 - https://github.com/kentcdodds/react-workshop-app/pull/26/checks?check_run_id=1222600601

the snapshot looks different there, so probably nothing I can do to make it pass, but please let me know if there is some trick to it :)

kentcdodds commented 4 years ago

I hope you don't mind, I wanted to make a few changes, so I'm opening a new PR. Will keep your commits though :) https://github.com/kentcdodds/react-workshop-app/pull/27