search

kentcdodds / react-workshop-app

An abstraction for all my React workshops
https://kentcdodds.com/workshops
MIT License
149 stars 37 forks source link

Production deploys messes up sorting of final solution and extra credit #30

Closed kentcdodds closed 4 years ago

kentcdodds commented 4 years ago

This only happens when we deploy:

image

Running the dev server works fine and building locally works fine as well. It's only when we actually deploy to production that we have problems 🤔

kentcdodds commented 4 years ago

I figured it out. Node v10 has a weird sorting issue. Not sure what it is, so I just updated netlify to use node 14.

I realize this means that currently our sorting will be wrong for Node v10 users and I'd love to get that fixed, but I've got too many things on my plate to deal with that right now.

Aprillion commented 4 years ago

Sorry if my change caused troubles, I can reproduce with Node 10.22.1, so looking into it...

FTR: I cannot run tests in Node 10 because of syntax error and I have no idea why optional chaining wasn't transformed by babel:

/Users/hozak/git/react-workshop-app/src/server.js:104
      if (JSON.stringify(req.body)?.includes('FAIL')) return true;
kentcdodds commented 4 years ago

No worries. I love your changes. Thanks 😁

--- original message --- On Fri, Oct 9 at 03:07 PM, notifications@github.com Peter Hozák wrote:

Sorry if my change caused troubles, I will have a look in Node 10..

—

You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub, or unsubscribe. --- end of original message ---