kentcdodds / react-workshop-app

An abstraction for all my React workshops
https://kentcdodds.com/workshops
MIT License
149 stars 37 forks source link

feat: remove window fetch mock and use MSW #8

Closed marcosvega91 closed 4 years ago

marcosvega91 commented 4 years ago

What:

I Have removed the mock of window.fetch and I have used for react-fundamentals example MSW

Why:

Because we don't want to mock fetch anymore

How:

1) Update MSW to last release 2) Remove window.fetch mock from setup-tests.js 3) Use MSW in test and app

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #8 into master will increase coverage by 0.25%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   82.02%   82.27%   +0.25%     
==========================================
  Files           4        4              
  Lines          89       79      -10     
  Branches       18       17       -1     
==========================================
- Hits           73       65       -8     
+ Misses         13       11       -2     
  Partials        3        3              
Impacted Files Coverage Δ
src/load-files.js 100.00% <ø> (ø)
src/setup-tests.js 100.00% <ø> (+13.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f3bb15...d8ef443. Read the comment docs.

kentcdodds commented 4 years ago

Whoops! This probably should have been a breaking change. I'm not going to do anything about it though because the epic react workshops are the only users that I'm actively supporting 😅

kentcdodds commented 4 years ago

@all-contributors please add @marcosvega91 for code and tests

allcontributors[bot] commented 4 years ago

@kentcdodds

I've put up a pull request to add @marcosvega91! :tada:

marcosvega91 commented 4 years ago

Yeeees it can be managed 🚀🚀

kentcdodds commented 4 years ago

:tada: This PR is included in version 2.15.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: