search

kentcdodds / testing-workshop

A workshop for learning how to test JavaScript applications
http://git.io/testing-workshop
1.36k stars 707 forks source link

Bump react-scripts to 1.0.7 #28

Closed thymikee closed 7 years ago

thymikee commented 7 years ago

Hey @kentcdodds, this is a fantastic resource for organising a testing workshop, thank you!

Since I've just started using it myself to teach about testing for my fellow coworkers, I thought it would be nice to give something back.

This PR bumps react-scripts to the latest, which comes with Jest@20 included, so no more weird hacks needed in package.json 😉.

Because of a bug in config resolving algo in Jest, nested configs need to point to your actual root directory (basically where process.cwd() points), hence rootDir explicitly added to these configuration files.

I've also removed testEnv() from jest commands, since Jest is supposed to do it for you. If this doesn't work on Windows for some reasons I can revert it (and file an issue in Jest repo).

kentcdodds commented 7 years ago

Since I've just started using it myself to teach about testing for my fellow coworkers

awesome!

Thanks so much for contributing back :)

kentcdodds commented 7 years ago

Thanks for the help! I'm not sure what's up with the build so we can figure that out later

thymikee commented 7 years ago

~You mean the cypress erroring? I got this before landing this PR too (just tested once more to be sure).~

EDIT: Discard cypress, it was just old version I had (basically this https://github.com/cypress-io/cypress/issues/369). So what's with your build? I works for me

kentcdodds commented 7 years ago

I'm basing this on this build. Something about jest: not found 🤔