search

kentcdodds / testing-workshop

A workshop for learning how to test JavaScript applications
http://git.io/testing-workshop
1.36k stars 708 forks source link

Calculator configuration could not pass test with cypress run #83

Closed weiklr closed 5 years ago

weiklr commented 6 years ago

Hi Kent,

I couldn't get the calculator test to pass when running with cypress run. It fails with the error: "Error: Unable to find an element with the text: /^1$/."

When I look at the screen shots, it was showing a list of files in dist folder instead of the calculator app and hence the error message.

To fix this, I updated the start command in other/configuration/calculator/package.json to: 

scripts:{
"start": "serve --port 8080"
}
kentcdodds commented 6 years ago

Thanks for the tip! Would you like to make a PR for this?

weiklr commented 6 years ago

Sure

On Thu, 5 Jul 2018, 10:18 PM Kent C. Dodds, notifications@github.com wrote:

Thanks for the tip! Would you like to make a PR for this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kentcdodds/testing-workshop/issues/83#issuecomment-402737527, or mute the thread https://github.com/notifications/unsubscribe-auth/AHhdYRJRBf-o4hWdOJr5nad2CnrSjSBEks5uDiAlgaJpZM4VC6m3 .

josephting commented 5 years ago

This should be closed.