Hey Kent, I like your coding style, and was reading your code, specifically I liked default optional object. While I was reading(top/bottom) double login kind of trip me out, even more so because I didn't notice login/logout definitions at the end. I understand you can't call auth.login with login, but still.
Would you consider merging this changes vis-a-vis readability, I really like underscore as a sign to point out private methods, and I feel this minor change adds to readability.
ultrox
commented
5 years ago
Hey Kent, I like your coding style, and was reading your code, specifically I liked default optional object. While I was reading(top/bottom) double login kind of trip me out, even more so because I didn't notice login/logout definitions at the end. I understand you can't call
auth.loginwithlogin, but still.Would you consider merging this changes vis-a-vis readability, I really like underscore as a sign to point out private methods, and I feel this minor change adds to readability.
Cheers!