search

kentcdodds / use-deep-compare-effect

🐋 It's react's useEffect hook, except using deep comparison on the inputs, not reference equality
https://npm.im/use-deep-compare-effect
MIT License
1.88k stars 84 forks source link

Warning during yarn install #35

Closed daveisfera closed 3 years ago

daveisfera commented 3 years ago

What you did: yarn add use-deep-compare-effect

What happened:

warning myproject > use-deep-compare-effect > @types/use-deep-compare-effect@1.5.1: This is a stub types definition. use-deep-compare-effect provides its own type definitions, so you do not need this installed.

Problem description: Warning about types from yarn install

Suggested solution: Remove dependency on @types/use-deep-compare-effect

kentcdodds commented 3 years ago

@daveisfera,

We don't have a dependency on @types/use-deep-compare-effect: https://github.com/kentcdodds/use-deep-compare-effect/blob/f5979ec228f87ceb8b459577c44c98bc76721cba/package.json#L27-L43

daveisfera commented 3 years ago

Sorry, looks like it was recently removed but hasn't been released yet: https://github.com/kentcdodds/use-deep-compare-effect/commit/9f0893541af05c181f90f5458c718a5aec6e1488#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

kentcdodds commented 3 years ago

Ah, thank you for opening this up! I'll get that released now.

kentcdodds commented 3 years ago

@all-contributors please add @daveisfera for bugs

allcontributors[bot] commented 3 years ago

@kentcdodds

I've put up a pull request to add @daveisfera! :tada:

kentcdodds commented 3 years ago

:tada: This is fixed in version 1.5.1 :tada:

The release is available on: