kentcdodds / use-deep-compare-effect

🐋 It's react's useEffect hook, except using deep comparison on the inputs, not reference equality

https://npm.im/use-deep-compare-effect

MIT License

1.88k stars 84 forks source link

fix readme links #38

Closed samuel-knutson closed 3 years ago

samuel-knutson commented 3 years ago

What:

Several links are broken in the README.md file. This impacts both the GitHub repository and the npm page.

Why:

Because broken links look sloppy and are distracting.

How:

Add missing links, which I found in the git history. You can check my fork to ensure the links are working.

Checklist:

[ ] Documentation N/A
[ x ] Tests
[ x ] Ready to be merged

More Details:

These links were originally added in this commit.
These links were removed in this commit. This seems like a simple mistake to me (not an intentional change).

codecov[bot] commented 3 years ago

Codecov Report

Merging #38 (8fc3ac4) into master (2f1c52f) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           20        20           
  Branches         5         5           
=========================================
  Hits            20        20

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f1c52f...8fc3ac4. Read the comment docs.

kentcdodds commented 3 years ago

@All-contributors please add @samuel-knutson for docs

allcontributors[bot] commented 3 years ago

@kentcdodds

I've put up a pull request to add @samuel-knutson! :tada:

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: