kentcdodds / webpack-validator-DEPRECATED

Use this to save yourself some time when working on a webpack configuration.
MIT License
93 stars 8 forks source link

Write validators for the webpack API #1

Closed kentcdodds closed 8 years ago

kentcdodds commented 8 years ago

I need help writing validators. Please see CONTRIBUTING.md file to find out how. Also check out configuration-validator documentation to see what a validator looks like.

I really need feedback on the API. Everything's in beta right now so we can mess around with the API as much as we want (rename things, restructure things, etc. etc.).

kentcdodds commented 8 years ago

I'm currently working on the entry property :-)

kentcdodds commented 8 years ago

entry has now been implemented. Validates that the file actually exists!

nyrosmith commented 8 years ago

@kentcdodds Which one would you like next? Do you mind creating an issue per validator so that keeping track is easier?

kentcdodds commented 8 years ago

@nyrosmith, if you have interest and a second, why don't you just file an issue for the specific property you'd like to write a validator for and we can do it that way :-)

kentcdodds commented 8 years ago

Skeleton validators are now in place. Simply go to a file like this and replace noop for a function which actually validates (docs).

nyrosmith commented 8 years ago

After fixing the debug validator I'll start implementing output validators

kentcdodds commented 8 years ago

:+1:

nyrosmith commented 8 years ago

Can we close this and create new issues per webpack-config option? Maybe beginner friendly tags could help too...

kentcdodds commented 8 years ago

Can we close this and create new issues per webpack-config option?

Yes, that'd be easier to track

Maybe beginner friendly tags could help too...

Agreed. I'd like to make a few of these first-timers-only issues as well...

I'm going to add you as a committer to the project if you don't mind. You're obviously motivated to contribute to this project :-) Please keep contributing via pull requests and I will too :-)

nyrosmith commented 8 years ago

I am very motivated :) I really hope you don't regret adding me as a committer. I tend to mess up things while playing around and learning things

kentcdodds commented 8 years ago

That's great! As long as you do that in pull requests I don't mind at all :-)