search

kentcdodds / webpack-validator-DEPRECATED

Use this to save yourself some time when working on a webpack configuration.
MIT License
93 stars 8 forks source link

feat(debug): Validate debug property #15

Closed nyrosmith closed 8 years ago

kentcdodds commented 8 years ago

Fantastic! Did you get things working on your machine?

kentcdodds commented 8 years ago

Also, if you're interested, you might check this out :+1: thanks again for your contribution! :D

nyrosmith commented 8 years ago

No, but I wanted to send this PR by all costs. Lint, test & test:configs work if I start them manually one after the other. And I need to disable ghook.

kentcdodds commented 8 years ago

Yeah, sorry about the ghook, I'm planning on changing it to opt-in so it's not a barrier to contributors: https://github.com/gtramontina/ghooks/issues/48

In the meantime, in case you're unaware, you can skip git hooks by adding the flag --no-verify to any command you execute which triggers a git hook.

nyrosmith commented 8 years ago

I will add your suggested changes tomorrow

kentcdodds commented 8 years ago

Thanks for working so hard on this, I'm sorry it's been such a nightmare :-/

kentcdodds commented 8 years ago

Sometime I'd like to do a video chat with you to figure out what's going on. When you start working on this do you wanna ping me about it?

nyrosmith commented 8 years ago

It is no nightmare, just another challenge ;)

Of course I'd like to chat. Just tell me when it fits for you. You have my mailaddress

nyrosmith commented 8 years ago

@kentcdodds I changed the message but I am not sure if I used --amend correct.. Can you pls take a look?

kentcdodds commented 8 years ago

Hi @nyrosmith, this looks great. If you look at the commits tab, you'll see that you have 3 commits for this one change. I can clean it up for you if you'd like. But if you'd like, you can squash the commits yourself

Let me know what you want to do :-)

nyrosmith commented 8 years ago

Can you pls do the cleanup? I am not that familiar with these commands.

kentcdodds commented 8 years ago

Sure! No problem. Thanks for working on this :-)

kentcdodds commented 8 years ago

I am not that familiar with these commands.

That's why I linked you to my video where I teach how to use the commands :-) But no worries. It's all cleaned up now. Thanks again for your contribution!