search

kentcdodds / webpack-validator-DEPRECATED

Use this to save yourself some time when working on a webpack configuration.
MIT License
93 stars 8 forks source link

Update npm dependencies & ReAdd npm-run-all #22

Closed nyrosmith closed 8 years ago

nyrosmith commented 8 years ago

We had to remove npm-run-all bc of cross platform issues This bug is fixed and I think it would be a good idea to update the deps & bring npm-run-all back

nyrosmith commented 8 years ago

@kentcdodds Maybe this is a good First-Timer issue?

kentcdodds commented 8 years ago

@nyrosmith totally! Want to make it? That'd be splendid!

nyrosmith commented 8 years ago

@kentcdodds It is not an urgent task so I thought maybe we find a new contributor. Then you have 2 new contributors to deal with :) I think we need more labels & some discussion of what I am allowed to do in your repos and what's not ok

kentcdodds commented 8 years ago

Yeah, I should probably update the CONTRIBUTING.md with something... I'll give it some thought.

Basically:

  1. Feel free to manage issues and PRs: open/close/label/etc.
  2. Please don't commit directly to master, discuss in PRs and get someone else to hit the green merge button

I'll apply this same thing to myself as well :-)

kentcdodds commented 8 years ago

Also, yeah, we could probably use more labels. I added a first-timers-only label. Feel free to set this issue up for that and add the label :+1:

kazekagegaara commented 8 years ago

So you want to revert to https://github.com/kentcdodds/webpack-validator/commit/c06f18842e7679eb983915119c871ab0cacf5398 ? If that is all, then I can take this task up.

kentcdodds commented 8 years ago

@kazekagegaara pretty much. Just make sure that you get the latest version of npm-run-all :+1:

nyrosmith commented 8 years ago

Closed by https://github.com/kentcdodds/webpack-validator/pull/24