search

kentcdodds / webpack-validator-DEPRECATED

Use this to save yourself some time when working on a webpack configuration.
MIT License
93 stars 8 forks source link

Fix issue #3 #28

Closed jonathanglasmeyer closed 8 years ago

jonathanglasmeyer commented 8 years ago

This fixes #3. In light of the multitude of possibilities for valid input strings i opted to just check for strings / strings in arrays / strings|arrays in object values.

kentcdodds commented 8 years ago

Left a few comments. This is awesome. Thanks! :+1:

jonathanglasmeyer commented 8 years ago

@kentcdodds Fixed those things.

kentcdodds commented 8 years ago

LGTM! Could we get one more reviewer on this? Feel free to hit the green button if it looks good to you!

sarbbottam commented 8 years ago

nice :red_circle: PR :+1: