kentcdodds / webpack-validator-DEPRECATED

Use this to save yourself some time when working on a webpack configuration.
MIT License
93 stars 8 forks source link

Replace path.parse with path-parse #35

Closed jonathanglasmeyer closed 8 years ago

jonathanglasmeyer commented 8 years ago

:octocat: Starter issue

We would like to take the opportunity to invite someone who did not yet contribute to webpack-validator to work on this issue. Follow @YourFirstPR on Twitter for more of these issues across many open source projects :)

:bug: The Problem

We want to support node v0.10, where path.parse from the node standard library isn't yet available. So path.parse should be replaced by using the npm module path-parse.

Steps:

kentcdodds commented 8 years ago

@jonathanewerner, please only add the first-timers-only label after the issue has been setup for a first timer (needs an extremely detailed checklist) :-)

Thanks! I hope we can give this to a first-timer!

jonathanglasmeyer commented 8 years ago

Ok! :+1: Is there some kind of canonical way to do this?

Edit: tried to come up with a basic checklist. :)

miguelc1221 commented 8 years ago

working on it = )

miguelc1221 commented 8 years ago

Sent pull request