search

kentcdodds / webpack-validator-DEPRECATED

Use this to save yourself some time when working on a webpack configuration.
MIT License
93 stars 8 forks source link

chore(commit): using commitizen for smart commit #36

Closed sarbbottam closed 8 years ago

sarbbottam commented 8 years ago

Closes #26

added npm run commit for smart commit messages.

kentcdodds commented 8 years ago

Lgtm

kentcdodds commented 8 years ago

Could we rebase this?

codecov-io commented 8 years ago

Current coverage is 100.00%

Merging #36 into master will not affect coverage as of 94d312c

@@            master     #36   diff @@
======================================
  Files           34      34       
  Stmts          214     214       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            214     214       
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of 94d312c

Powered by Codecov. Updated on successful CI builds.

sarbbottam commented 8 years ago

Rebased with upstream/master and resolved merge conflicts

kentcdodds commented 8 years ago

Do you mind adding the commitizen friendly badge?

[![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg?style=flat-square)](http://commitizen.github.io/cz-cli/)

And maybe add a note in CONTRIBUTING.md. Sorry I didn't ask you to do this earlier :-/

sarbbottam commented 8 years ago

No worries, sorry for the delayed response, Monday :large_blue_circle:

kentcdodds commented 8 years ago

Looks great!