search

kentcdodds / webpack-validator-DEPRECATED

Use this to save yourself some time when working on a webpack configuration.
MIT License
93 stars 8 forks source link

fix(path-parse): Replace path.parse with polyfill #42

Closed miguelc1221 closed 8 years ago

miguelc1221 commented 8 years ago

Replaced path.parse with with path-parse

sarbbottam commented 8 years ago

Could you update the commit message to add Closes #35 and use fix instead of feat?

You could use git commit --amend and then

fix(path-parse): Replace path.parse with polyfill

Closes #35
kentcdodds commented 8 years ago

Looks great! Just a few things to iterate on. If you need help, I'm happy to do a video chat and help you out!

miguelc1221 commented 8 years ago

ok fixed it! learned some new git commands today = ), Thanks a lot for the opportunity.

kentcdodds commented 8 years ago

This is perfect!

kentcdodds commented 8 years ago

:tada: Welcome to the committer's side of the Open Source community!!!!

giphy