kentnl / Devel-Isa-Explainer

Pretty Print Function Hierarchies of Classes
Other
1 stars 0 forks source link

Suggestions w/ Key/Legend changes #8

Open kentfredric opened 8 years ago

kentfredric commented 8 years ago
<haarg> kentnl: in Devel-Isa-Explainer, i'd suggest using "Legend" rather than "Key".  possibly with an option to hide it.
*** Mode #moose +o osfameron by GumbyNET5
<haarg> http://paste.scsys.co.uk/516146 also maybe something like this.  or maybe aligning things differently.
<haarg> it isn't very clear to read currently
<kentnl> haarg: yeah. EFUTURE.  Actual implementation details of that aren't settled yet so I don't want to prematurely expose config options.
<kentnl> there's a few other things I have to sort out there specifically  as well :/
diff --git i/lib/Devel/Isa/Explainer.pm w/lib/Devel/Isa/Explainer.pm
index cb213fa..313b663 100644
--- i/lib/Devel/Isa/Explainer.pm
+++ w/lib/Devel/Isa/Explainer.pm
@@ -101,21 +101,18 @@ sub _pp_sub {

 sub _pp_key {
   my @tokens;
-  push @tokens, 'Public Sub: ' . _hl_PUBLIC('foo_example');
-  push @tokens, 'Type Constraint: ' . _hl_TYPE('TypeName');
-  push @tokens, 'Type Constraint Utility: ' . _hl_TYPE_UTIL('typeop_TypeName');
-  push @tokens, 'Private/Boring Sub: ' . _hl_PRIVATE('foo_example');
+  push @tokens, _hl_PUBLIC('public_sub');
+  push @tokens, _hl_TYPE('TypeConstraint');
+  push @tokens, _hl_TYPE_UTIL('utility_ForTypeConstraint');
+  push @tokens, _hl_PRIVATE('private_or_boring_sub');
   if ($SHOW_SHADOWED) {
-    push @tokens, 'Public Sub shadowing another: ' . _hl_PUBLIC( 'shadowing_example', 0, 1 );
-    push @tokens, 'Public Sub shadowed by higher scope: ' . _hl_PUBLIC( 'shadowed_example', 1 );
-    push @tokens, 'Public Sub shadowing another and shadowed itself: ' . _hl_PUBLIC( 'shadowed_shadowing_example', 1, 1 );
-
-    push @tokens, 'Private/Boring Sub shadowing another: ' . _hl_PRIVATE( 'shadowing_example', 0, 1 );
-    push @tokens, 'Private/Boring Sub shadowed by higher scope: ' . _hl_PRIVATE( 'shadowed_example', 1 );
-    push @tokens, 'Private/Boring Sub another and shadowed itself: ' . _hl_PRIVATE( 'shadowing_shadowed_example', 1, 1 );
+    push @tokens, _hl_PUBLIC( 'shadowing_sub', 0, 1 );
+    push @tokens, _hl_PUBLIC( 'shadowed_sub', 1 );
+    push @tokens, _hl_PRIVATE( 'private_shadowing_sub', 0, 1 );
+    push @tokens, _hl_PRIVATE( 'private_shadowed', 1 );
   }
   push @tokens, 'No Subs: ()';
-  return sprintf "Key:\n$INDENT%s\n\n", join qq[\n$INDENT], @tokens;
+  return sprintf "Legend:\n$INDENT%s\n\n", join qq[\n$INDENT], @tokens;
 }

 sub _mg_sorted {