kentnl / File-ShareDir-ProjectDistDir

Simple set-and-forget using of a '/share' directory in your projects root
Other
5 stars 5 forks source link

Requirement for Perl 5.10.1+ #1

Closed jjn1056 closed 12 years ago

jjn1056 commented 12 years ago

Hi,

I make heavy use of your distribution for DBIx::Class::Migration and it works really well. However in your latest release you are requiring a new version of Perl then is supported by my company. I feel your pain on this issue but I don't see anything in your codebase that is v5.10.1+ specific (as far as I can tell all your tests pass on the older Perl) so I would ask if you could consider following the Moose cabal's rule, which is you don't support Perl's older than 5.10.1 but your won't explicitly stop someone from trying to install it. Right now I can't even try, since the version requirement is part of the build.

I hate to be in the position of making this request, but unless there is a code reason, like some Perl 5.10.1 feature you really need to have in order to make your project work, I would appreciate you accommodation on this.

John Napiorkowski

kentfredric commented 12 years ago

Yeah, Incidentally I did look at your code and did a quick scan, but it didn't explicitly state what version you were using so I got my hopes up =)

Though I'm glad its useful to you.

The primary reason for the 5.10.1 dep is that I've been informed that apparently 3-part versions "don't work" in version-specific dependencies on versions before 5.10.

ie: Allegedly, you cant do use FSTD 0.4.0 and have it JustWork on <5.10

Your thoughts as how to proceed are of course greatly appreciated =)

kentfredric commented 12 years ago

Ok, after much debate on toolchain, I have a proposal and I want to see if its acceptable.

  1. I'll drop the version dep on 5.10
  2. next version is 0.3.1
  3. If you want to depend on 0.3.1 as a minimum version, you may have to do so as follows:

use version 0.77;
use File::ShareDir::Project 0.3.1;

Which I'm told will work.

If you're open to this idea and don't mind reporting any bugs you happen to see with using dotted decimal, that'd be great =)

jjn1056 commented 12 years ago

I'm willing to give it a go. Again, sorry to cause all this trouble. When I see it on CPAN I will adjust and promote.

Thanks for being willing to engage me on this! You module is really handy, saves me a lot of boilerplate code and really helps promote using widely accepted community standards.

John

kentfredric commented 12 years ago

https://metacpan.org/release/KENTNL/File-ShareDir-ProjectDistDir-0.3.1

Thanks. I'll leave this bug up till you're satisfied =)

jjn1056 commented 12 years ago

So DBIC:Migration 0.014 is on the way to cpan. installs for me and I will watch CPAN testers for any interesting reports. I'll go ahead and close this now, but I might come back to you if I see anything that is fixable.

Thanks again for working on this with me!