search

kentonl / e2e-coref

End-to-end Neural Coreference Resolution
Apache License 2.0
518 stars 174 forks source link

Small issue at setup_pretrained.sh last commit #50

Closed GorkaUrbizu closed 5 years ago

GorkaUrbizu commented 5 years ago

Hi,

The last commit of 2 days ago updated the script for setup_pretrained (some dowload links for the resources were not available), and I think that you forget to remove an old command:

old commit:

curl -O http://lsz-gpu-01.cs.washington.edu/resources/coref/$ckpt_file

new commit:

download_from_gcs $ckpt_file curl -O http://lsz-gpu-01.cs.washington.edu/resources/coref/$ckpt_file

In the new commit, I would say that the second line is the old link duplicated.

kentonl commented 5 years ago

Great catch! f051f3ad143cb1db040f3fafe27d6de169f7ad6e fixes this.