Forcing use of Python 2 where Python3 is incompatible

kentonl / e2e-coref

End-to-end Neural Coreference Resolution

Apache License 2.0

518 stars 174 forks source link

Forcing use of Python 2 where Python3 is incompatible #67

Closed Pab0 closed 4 years ago

Pab0 commented 4 years ago

When running setup_training.py in a Python3 environment, the following scripts throw syntax errors:

skeleton2conll.py from cemantix

except InvalidSexprException, e:

get_char_vocab.py https://github.com/kentonl/e2e-coref/blob/10c6fb6b774b1a80724f6b7fdc68d743b6a88e99/get_char_vocab.py#L19

Forcing use of Python2 for these scripts allows setup_training.py to execute successfully.

kentonl commented 4 years ago

Thanks for sending this. I'd prefer not checking this in, since I'm not sure how compatible it is with all the different environments out there.

However, the lack of PY3 support in get_char_vocab.py is indeed a bug and that's been fixed in 9d1ee1972f6e34eb5d1dcbb1fd9b9efdf53fc298

ghost commented 3 years ago

From my POV using this repository for a research study, the repo appears to be broken "as is" for the reasons stated in the PR.

After I include these two commits, my issues with ./setup_training.sh are resolved. If you choose not to check these changes in, I would recommend at least linking this PR in the relevant section of the readme.