search

kentonv / etherpad-lite

Really real-time collaborative document editing for the rest of us
http://etherpad.org
Apache License 2.0
30 stars 11 forks source link

Pad settings don't save #17

Open ovizii opened 8 years ago

ovizii commented 8 years ago

After checking the boxes for "chat always on screen" and "show chat and users" and switching between different grains, closing the etherpad grain, and opening it again, the settigns seem lost.

kentonv commented 8 years ago

To be clear, do you only care that settings save across refreshes of the same grain, or do you want settings applied on one grain to apply to other grains? The latter would be hard without some new feature in Sandstorm since grains cannot communicate with each other unless you explicitly connect them. The former is possible, though.

ovizii commented 8 years ago

I'd be quite happy if my preferences would be saved across refreshes of the same grain but ideally one could save one's preferences for grains belonging to this app and have them applied to every future grain of this app. I don't think the grains need to communicate, one just needs an option of settings and saving one's preferences so all future grains will be created with this set of prefs.

kentonv commented 8 years ago

The problem is, if any Etherpad grain is able to modify the preferences that all grains see, then they can use this as a covert communications channel. Some of our security guarantees depend on there being no such channels.

To solve this, we could perhaps allow an app to offer a settings UI which is sandboxed separately from any grain. We can then have a one-way information flow from the settings UI to the grains. I think this would be a great feature to have but I'm not sure when we'll have a chance to implement it.

ovizii commented 8 years ago

I understand and I know its beta so no stress. I was just pointing out that people might want different defaults/settings than the person who packaged the app :-)

I'd be happy if a grain of etherpad would at least remember its own settings.

kentonv commented 8 years ago

Yep, this feedback is definitely valuable. Thanks!

ocdtrekkie commented 8 years ago

Another way to do this, depending on the tech savviness of the person involved, is to fork the app and set your defaults in it. (This may require less code or more code depending on the app in question.) At some point, hopefully, Sandstorm will support forked apps better than it does now, in terms of moving documents between them.

-Jake Weisz

On Mon, Nov 30, 2015 at 1:26 PM, Kenton Varda notifications@github.com wrote:

Yep, this feedback is definitely valuable. Thanks!

— Reply to this email directly or view it on GitHub https://github.com/kentonv/etherpad-lite/issues/17#issuecomment-160732748 .

ovizii commented 8 years ago

thx, I guess that's an option. personally, atm I'd rather change my view every time I am using etherpad :-)

zeigerpuppy commented 8 years ago

It would be really useful to have some user based defaults for all grains, this may actually be a good upstream issue too. For etherpad, it would be nice if the user could set their: