search

kentonv / etherpad-lite

Really real-time collaborative document editing for the rest of us
http://etherpad.org
Apache License 2.0
30 stars 11 forks source link

Comment threads don't get updated correctly #26

Closed zarvox closed 7 years ago

zarvox commented 7 years ago

To reproduce:

I would expect that when user A hovers over their comment, they should see their comment and user B's reply.

Instead, they see just their own comment.

Additionally, if user B makes a comment elsewhere in the pad, user A will see that range highlighted, but when user A hovers over that range, they see the first thread, rather than the new comment.

kentonv commented 7 years ago

I would expect that when user A hovers over their comment, they should see their comment and user B's reply.

This is fixed by: https://github.com/kentonv/ep_comments/commit/c8f6ce84aa65a51b24c7aab73e6261ef8e5b57cd

Additionally, if user B makes a comment elsewhere in the pad, user A will see that range highlighted, but when user A hovers over that range, they see the first thread, rather than the new comment.

I'm unable to reproduce this, although I think I have observed it in the past. Can you provide more specific reproduction steps, starting from creating the pad?

zarvox commented 7 years ago

I tried for a bit to get the second bug to reproduce, but I also couldn't make it happen again. I wouldn't be surprised if the fix you made also happens to fix the second symptom, so I'll close this issue and open a new one if I encounter the odd behavior again.