kentonv / etherpad-lite

Really real-time collaborative document editing for the rest of us
http://etherpad.org
Apache License 2.0
30 stars 11 forks source link

Restoring line numbers #34

Open ttx opened 7 years ago

ttx commented 7 years ago

Line numbers are useful to refer to a specific zone in the document while collaboratively discussing it, but the ep_author_neat plugin replaces them.

Consider adding something like https://github.com/clkao/ep_author_neat/pull/18 to restore them, as well as an option for enabling/disabling them (real "Show line numbers")?

kentonv commented 7 years ago

To be clear, this isn't a recent regression in the Sandstorm package, right? I made some big changes to that sidebar this week but I don't think the line numbers were there before, either.

I suppose now that we show avatars rather than text names in the sidebar, restoring the line numbers would actually work well. They'd be obscured by avatars but the avatars don't usually show on every line so you can figure out from the adjacent lines.

ttx commented 7 years ago

Confirmed, it's not a regression in Sandstorm package. It's just a well-known limitation of the ep_author_neat plugin, and since you are using a fork for the sandstorm package, we may have an opportunity to fix it there. Thanks!