kenwheeler / slick

the last carousel you'll ever need
kenwheeler.github.io/slick
MIT License
28.52k stars 5.88k forks source link

Dots appearing when not enough slides #3152

Open tycooper opened 7 years ago

tycooper commented 7 years ago

First, thanks for the script. It is fantastic!

We've run into an issue where dots are appearing even when there are not enough slides present. It seems this worked correctly back in 1.6.0 but was broken in 1.7.1

====================================================================

[ https://jsfiddle.net/b1zmzhn4/1/ ]

use this jsfiddle to reproduce your bug: http://jsfiddle.net/simeydotme/fmo50w7n/ we will likely close your issue without it.

====================================================================

Steps to reproduce the problem

Set slides to show to 3. Set slides to scroll to 3. If you have less slides than this and dots set to true, they still appear even though there is no where to scroll to.

====================================================================

What is the expected behaviour?

Dots should not appear.

====================================================================

What is observed behaviour?

Dots do appear

====================================================================

More Details

tycooper commented 7 years ago

Actually, we've discovered the issue. The packaged download on the GitHub page points at 1.8.0. If you go through the repo, the version is 1.8.1. The minified version is still 1.8.0 though, and the issue is present in that file, but 1.8.1 full build fixes it.

fnagel commented 6 years ago

Related to #3009 and #3323

Can confirm it works when not using the minified version of 1.8.1. Be careful there is a markup change hidden in the "real" 1.8.1, see https://github.com/kenwheeler/slick/issues/3323#issuecomment-365695192

Thanks @tycooper for the hint!

bpakhrin89 commented 4 years ago

Is this fixed yet? or do I have to use the full build version?

lhguerra commented 3 years ago

Come on, guys, this is already fixed for years, why the hell can't we have it in the minified version?