search

kenwheeler / slick

the last carousel you'll ever need
kenwheeler.github.io/slick
MIT License
28.48k stars 5.88k forks source link

Slick broken in Chrome 69.0.3497.100 #3591

Open lottieseo opened 5 years ago

lottieseo commented 5 years ago

Have development site with slider at top of the page, works fine in all browsers apart from latest Chrome version

http://satec.foamydev.com/

Errors

jquery.min.js:2 [Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

jquery.min.js:2 [Violation] 'setTimeout' handler took 68ms

Anikethana commented 5 years ago

+1 i am seeing the same issue

karl-sjogren commented 5 years ago

This is a limitation in jQuery. It also won't be fixed until jQuery 4.0 according to https://github.com/jquery/jquery/issues/2871

It shouldn't break anything though, it is just a warning (works great for me even though Chrome has been warning for this in the canary version for ages).

nlxdodge commented 3 years ago

See #3105 #3422 they are linked to the same issue. The update is that the fix has been made, but not yet approved.

nicolaskopp commented 3 years ago

you may use https://github.com/nicolaskopp/slick in the meantime, which has support for passive listeners. Lighthouse reports no issues and the pagespeed is good with this one.

doughballs commented 3 years ago

Interesting...I presume correct usage here is to just replace the existing slick directory with yours?

If I do this, the violations still show up in lighthouse, and if I change to slick.js (instead of using slick.min.js that I was using), the thing breaks altogether with a Uncaught TypeError: $(...).slick is not a function