search

kenwheeler / slick

the last carousel you'll ever need
kenwheeler.github.io/slick
MIT License
28.53k stars 5.88k forks source link

issue #1693 looks like its broken again in 1.9.0 #3612

Open umbalem opened 6 years ago

umbalem commented 6 years ago

https://github.com/kenwheeler/slick/issues/1693

(not sure how to correctly format this.. sorry)

Behavior described in issue #1693 seems to be happening to me in 1.9.0

Filtering breaks on mobile breakpoints. It works the first time, but filtering again no items are shown. It works fine on full screen.

Filter works after removing the responsive table init. I have reverted back to 1.5.9 and everything works.

pnmcosta commented 6 years ago

Yup, I can confirm, have the same issue, change https://s.codepen.io/pnmcosta/debug/EdJNVJ/PBkNWNjRnKJM to mobile responsive and you can reproduce it.

Editable: https://codepen.io/pnmcosta/pen/EdJNVJ

michalsedlacko commented 6 years ago

I can confirm too. Have some1 any hint?

jeffreyducharme commented 5 years ago

Still seeing this issue :(

pnmcosta commented 5 years ago

I delved, unfortunately couldn't figure out why, code seems ok... Published the site (https://www.zximenes.com/) anyway, hopefully it will be fixed soon.

muster-mark commented 5 years ago

Also been having this problem for a while (using v1.8.1), meaning I've got to stick to 1.5.9.

oilvier commented 5 years ago

Hi,

I can't explain why, but it seems to be linked with the rows option. If you set it to rows: 0 (it's what you need in most of the cases anyway) the problem disappears.

It could be a sufficient fix until a proper solution is found.

pnmcosta commented 5 years ago

@oilvier thanks, I can confirm setting rows:0 to the breakpoints fixes it.

Great spot, thanks :)

P.s. I've updated the example with the fix: https://codepen.io/pnmcosta/pen/EdJNVJ

patrick-wc commented 5 years ago

rows: 0 added to each breakpoint, not just on the main .slick({ call worked for me. This fix should be added to the documentation, along with an example of how to filter by a CSS class.

dimitur2204 commented 3 years ago

@olivier Incredible spot. Works for 1.8.0 too. @oilvier

xahid07 commented 2 years ago

@oilvier Mindblowing solution. Thank you so much.