Updates for jQuery 3.0+ and deprecations

kenwheeler / slick

the last carousel you'll ever need

kenwheeler.github.io/slick

MIT License

28.33k stars 5.88k forks source link

Updates for jQuery 3.0+ and deprecations #4221

Open smartexcan opened 1 year ago

smartexcan commented 1 year ago

jQuery migrate warnings

Replace deprecated $.type with typeof, Array.isArray or $.isPlainObject where appropriate.
Fix invalid self-closing html tags (div, button, ...)
Fix hard-coded number values in calls to jQuery.fn.css( (property), value )
Replace deprecated document ready signature in index.html

slick.min.js was not changed since it was still missing some previous changes to main file, it should probably just be re-minified.

ribeiroeder commented 3 months ago

@ahmadalfy can you check this? jQuery 4 completely removed support for the "$.type" and "$.isArray" functions used in slick's current code and this PR fixes them with their native equivalents.

andrewcbi commented 2 months ago

@pablo67340 This should be merged into next build. I've been using this in production since Dec 2022.