FIX: Add font display swap for optimization

kenwheeler / slick

the last carousel you'll ever need

kenwheeler.github.io/slick

MIT License

28.33k stars 5.88k forks source link

FIX: Add font display swap for optimization #4244

Closed viclen closed 3 months ago

viclen commented 1 year ago

According to google Lighthouse, you should ensure text remains visible during webfont load (.woff).

More info in here.

yashvekaria commented 1 year ago

Can you please merge #4244.

markvantilburg commented 3 months ago

@ahmadalfy this one looks good to me

ahmadalfy commented 3 months ago

This one is debatable. While it fixes the score, it doesn't seem to be right. The swap value will display the broken unicode character until the font is downloaded. I don't think that's correct. Let me experiment and see the result

markvantilburg commented 3 months ago

The default chars are in the spec since 1993, i'm not sure if there are "default" fonts that don't support these Dot: https://unicodeplus.com/U+2022 Left: https://unicodeplus.com/U+2190 Right: https://unicodeplus.com/U+2192

Are there other chars than these 3?

ahmadalfy commented 3 months ago

No, it's only three characters. I stand corrected, this will be a great addition.