search

kenwheeler / slick

the last carousel you'll ever need
kenwheeler.github.io/slick
MIT License
28.53k stars 5.89k forks source link

Selecting/Highlighting text #826

Open asnoba opened 9 years ago

asnoba commented 9 years ago

Hi,

I'm not sure whether this is a feature request or a bug, but as far as I can tell selecting/highlighting text in the active slide isn't possible – even if the draggable option is set to false. I think a fix for this would be nice for accessibility reasons. Any ideas?

I've included an example here: http://codepen.io/asnoba/full/yyNOQj/

BR, Asger

asnoba commented 9 years ago

Maybe user-select: none should only be set when draggable is true?

bjmiller121 commented 9 years ago

+1

I have to override this in order to make text in the slide selectable.

.slick-slider {
  -webkit-user-select: text;
  -khtml-user-select: text;
  -moz-user-select: text;
  -ms-user-select: text;
  user-select: text;
}
.slick-list.draggable {
  -webkit-user-select: none;
  -khtml-user-select: none;
  -moz-user-select: none;
  -ms-user-select: none;
  user-select: none;
}
simeydotme commented 9 years ago

This could potentially be a bad backwards-breaking change; consider there could be thousands of websites which take this current CSS as the default and rely on it.

I actually agree on the premise: It should only be un-selectable when it's a draggable-slider; but i think the change should go in to a minor/major release milestone :smile:

Si.

kenwheeler commented 9 years ago

@simeydotme agreed. On deck for 1.4.

jmcglone commented 9 years ago

Agreed and +1 for setting user-select: none when draggable is true

I see this was added and then removed from milestone 1.4–any plans to add to future milestones?

safareli commented 8 years ago

why was this removed?

reloaded commented 8 years ago

@simeydotme Any idea if this feature is going to be implemented? Why was it decided to not implement this (or not document it)?

nanastya commented 7 years ago

Issue still exists. I'm sure a lot of developers would really appreciate if it was solved finally. Please, kenwheeler, help us out :)

lingtalfi commented 7 years ago

+1

skyyip commented 7 years ago

First Set the option to draggable: false , Then override the css:

.slick-slider {
  -webkit-user-select: text;
  -moz-user-select: text;
  -ms-user-select: text;
  user-select: text;
}
pedroadame commented 7 years ago

+1

artursopelnik commented 7 years ago

+1 - pls add this to core