search

kenzzii / mtchart

Automatically exported from code.google.com/p/mtchart
GNU General Public License v3.0
0 stars 0 forks source link

Unify coding standards #6

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Hi,

It is great to see pChart is forked. However, as I ever told original
author, pChart code does not comply to PHP coding standard which requires

+ Namespace should be in lowercase
+ Class name must be in form of CamelCase
+ Public methods/properties, local variable must be in camelCase
+ Protected methods and properties should be in _camelCase
+ Constants are all in UPPER_CASE

He agreed with me and said that he would release the next version with
those changes. But he didn't come back ever since.

However, I believe that coding standard is still important. Using the same
coding standard as in Zend, CakePHP, PEAR, PECL, Symfony make mtChart more
compelling to adopt soon.

mtChart is new and not popular so the cost of this change would be small.
When it becomes popular I think that such a change can be costly and annoying.

If you need help, please let me know.

Original issue reported on code.google.com by pcdinh on 17 Jul 2009 at 8:40

GoogleCodeExporter commented 8 years ago 
I agree and some standardizing already has taken place. And I also agree that 
mtChart is young enough to 
change these now.

(I'm offline for the next two weeks, it will have to wait.)

Original comment by 128625 on 18 Jul 2009 at 8:15