search

keolo / mixpanel_client

Ruby interface to the Mixpanel Data API
MIT License
148 stars 72 forks source link

Remove deprecated authentication options #55

Closed whatthewhat closed 7 years ago

whatthewhat commented 7 years ago

The api_key and expire options seem to have been used by the deprecated authentication (see https://mixpanel.com/help/reference/data-export-api#authentication), but were not completely removed from this gem.

Additionally api_key is currently required for the gem to work, but is not actually used anywhere in the codebase.

Also added a commit that fixes some rspec warnings and deprecations, they really bugged me when running the test suite locally 😄

keolo commented 7 years ago

This is a great pull request! Thanks for updating the rspec warnings. The test suite is in sore need of an update. :)

whatthewhat commented 7 years ago

Thanks! I really like what you've planned in https://github.com/keolo/mixpanel_client/projects/1, btw 😉