search

keolo / mixpanel_client

Ruby interface to the Mixpanel Data API
MIT License
148 stars 72 forks source link

Added timezone to Available Options #7

Closed jasonlogsdon closed 12 years ago

jasonlogsdon commented 12 years ago

I just added it to the OPTIONS array and to the reset in the gem spec. Seemed to work just fine during my testing.

Thanks!

keolo commented 12 years ago

Thanks I'll try to merge that in and push a new gem this week.

jasonlogsdon commented 12 years ago

Thanks, I appreciate it!

On Thursday, November 17, 2011, Keolo Keagy < reply@reply.github.com> wrote:

Thanks I'll try to merge that in and push a new gem this week.

Reply to this email directly or view it on GitHub: https://github.com/keolo/mixpanel_client/pull/7#issuecomment-2782341

jasonlogsdon commented 12 years ago

I have a quick question, since I haven't done forking before. I see that the changes are now showing up on Github but if I do a gem install mixpanel_client they don't seem to show up there. Is there something I need to do to have the gem update with the current repo?

Thanks again for your help, I really appreciate it! Jason

On Thu, Nov 17, 2011 at 4:43 PM, Jason Logsdon jason.logsdon@gmail.comwrote:

Thanks, I appreciate it!

On Thursday, November 17, 2011, Keolo Keagy < reply@reply.github.com> wrote:

Thanks I'll try to merge that in and push a new gem this week.

Reply to this email directly or view it on GitHub: https://github.com/keolo/mixpanel_client/pull/7#issuecomment-2782341

keolo commented 12 years ago

Hi Jason,

I've merged your changes into the repo but haven't created and pushed a new version of the gem to rubygems. I'll try to get that done tonight (there's another issue I'd like to pull in to). Sorry for the delay. Btw, you may be able to link to this repo directly if you're using bundler.

jasonlogsdon commented 12 years ago

Oh, no problem at all, I just wanted to make sure I wasn't doing something wrong on my side. Thanks again for you help, I appreciate it!

On Tue, Nov 22, 2011 at 4:07 PM, Keolo Keagy < reply@reply.github.com

wrote:

Hi Jason,

I've merged your changes into the repo but haven't created and pushed a new version of the gem to rubygems. I'll try to get that done tonight (there's another issue I'd like to pull in to). Sorry for the delay. Btw, you may be able to link to this repo directly if you're using bundler.

Reply to this email directly or view it on GitHub: https://github.com/keolo/mixpanel_client/pull/7#issuecomment-2840687