search

keon / algorithms

Minimal examples of data structures and algorithms in Python
MIT License
24.13k stars 4.61k forks source link

pip installing problem #469

Open Notheryne opened 5 years ago

Notheryne commented 5 years ago

I found a problem with installing algorithms via pip - it doesn't install all the algorithms. The problem is found on Windows 7 64bit proffesional and i can't really test this on any other computer, but I was just trying it around and got this:

ImportError: cannot import name 'caesar_cipher' from 'algorithms.strings' (C:\Users\Me\AppData\Local\Programs\Python\Python37\lib\site-packages\algorithms\strings__init__.py)

So i went into cmd and located the directory, and there are a few algorithms missing: git

I tried --upgrade and reinstalling the library, but it is like this all the time. Tried this today when i saw a new commit with k_nearest_points, and this algorithm isn't included as well.

bsushmith commented 5 years ago

I think its just that the pypi repo is not up to date and needs to be updated.

goswami-rahul commented 5 years ago

I think @bsushmith is right. I ping @keon to update the repo in pypi.

Notheryne commented 5 years ago

Thought so, but couldn't resolve it myself and I think this library is too nice to be outdated :)

keon commented 5 years ago

@Notheryne @goswami-rahul @bsushmith thanks so much for flagging this. I'll update PyPI by EOD.

ramboisyuanbo commented 4 years ago

@Notheryne @goswami-rahul @bsushmith thanks so much for flagging this. I'll update PyPI by EOD.

Hi Keon, as for today, pip install still does NOT have all the sub-directories listed here. e.g. the tree directory. By the way, any chance to add a parsing algorithm for tree? E.g., input some pre-order token list, output a tree‘s root Node ? Maybe that's not clean to include in your project.