keon / algorithms

Minimal examples of data structures and algorithms in Python
MIT License
23.77k stars 4.59k forks source link

Add num_perfect_squares #767 #848

Closed mantaur closed 2 years ago

mantaur commented 2 years ago

The original implementation by @ntomsic for #767 with an open PR wanted these changes:

But since the requested changes from 25/04/2021 haven't been fixed yet, I assumed @ntomsic has dropped this. Another pr for #767 was opened: https://github.com/keon/algorithms/pull/793 , however @rashidkalwar didn't implement the requested changes. This pr fixes #767 the requested changes and improves documentation.

ankit167 commented 2 years ago

Please resolve conflicts

mantaur commented 2 years ago

@ankit167 Done!