search

keotl / ohdieux

A podcast feed converted for Radio-Canada Ohdio / Un convertisseur de flux de balados pour Radio-Canada Ohdio
https://ohdieux.ligature.ca
GNU Affero General Public License v3.0
31 stars 5 forks source link

Added QR code for generated URL #21

Closed philippec closed 8 months ago

philippec commented 8 months ago

Hello,

I added a QR code to represent the generated URL so that it's easy to scan the URL with your phone if you loaded ohdieux on another device (e.g. your friend's phone or computer).

This adds a dependency to https://davidshimjs.github.io/qrcodejs/ but I wasn't sure if you were OK with that. It could be a ~20kb local JS file too, as there is a minified version as well.

I tested this locally and it worked fine in Safari, Chrome, and Firefox.

keotl commented 8 months ago

Hi there, thanks for the contribution. Looks and feels great!

As a note, there seems to be something slightly funny going on with the owner of the CDN repo/NPM package not being the original author, so I'll put in a quick fix after merging to inline the original library instead.