search

kepazon / mvc-mini-profiler

Automatically exported from code.google.com/p/mvc-mini-profiler
0 stars 0 forks source link

</link> tag not being rendered nor is a self-closing tag #90

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
HTML validators do not validate the <link> tag the mini-profiler renders 
beacause it does not render the end tag nor it renders it as a self closing tag.

Steps to reproduce:
1. Include the following line in the layout or View:
    @MvcMiniProfiler.MiniProfiler.RenderIncludes() 
2. Run the page and view the source in your browser

Expected output:
<link rel="stylesheet" type="text/css" 
href="/mini-profiler-includes.css?v=1.7.0.0"/>

What you get instead:
<link rel="stylesheet" type="text/css" 
href="/mini-profiler-includes.css?v=1.7.0.0">

Original issue reported on code.google.com by hdjar...@gmail.com on 15 Aug 2011 at 8:21

GoogleCodeExporter commented 9 years ago 
Something to note here, the end tag would be bad...it's actually forbidden in 
HTML4 (http://www.w3.org/TR/html4/struct/links.html#h-12.3) which is what we're 
targeting with the profiler on stackoverflow.com (the output is valid in that 
case).

Perhaps a tag self-closing option on RenderIncludes() specifically would make 
the most sense here? Thoughts?

Original comment by nrcraver on 16 Aug 2011 at 11:08

GoogleCodeExporter commented 9 years ago 
yeah we should add an option to specify xhtml if the consumer elects

Original comment by sam.saff...@gmail.com on 18 Aug 2011 at 1:10

GoogleCodeExporter commented 9 years ago 
fixed in latest: 

@MiniProfiler.RenderIncludes(xhtml: true)

Original comment by sam.saff...@gmail.com on 26 Aug 2011 at 2:32