search

kepi / chromeEyeDropper

Eye Dropper and Color picker extension for Google Chrome
https://eyedropper.org
210 stars 73 forks source link

It doesn't work for retina displays #67

Closed matthijsgroen closed 10 years ago

matthijsgroen commented 10 years ago

On retina displays, you have to move the cursor twice as far down and twice as far right to get the right color

kepi commented 10 years ago

Uff, this will be really hard for me to debug as I don't have any retina display. Anyway I will probably not be able to get to this before christmas, sorry for inconvinience.

jasperjorna commented 10 years ago

I'm experiencing this issue on my retina Macbook aswell.

If I can be of any help to test or debug something, let me know.

garrypolley commented 10 years ago

I can also verify that this affects me on my retina display macbook pro as well. Running chrome version: 31.0.1650.63

matthijsgroen commented 10 years ago

What is the best approach to set it up locally and help development?

kepi commented 10 years ago

You can simply checkout last version and in Chrome extensions tab (chrome://extensions/) check developer mode and than load unpacked extension (not sure about exact name, I have localized chrome - not english one) and point to directory with checked out version.

Then simply use inspect tools etc.

kepi commented 10 years ago

Can anybody with retina please try my attempt to fix? I still don't have access to any retina computer so it is hard for me.

  1. download https://github.com/kepi/chromeEyeDropper/archive/retina.zip
  2. unpack to some path on your disk
  3. Click the Chrome menu icon and select Extensions from the Tools menu. Ensure that the "Developer mode" checkbox in the top right-hand corner is checked.
  4. Click on load unpacked directory and point it to place you unzipped downloaded file
  5. another eye dropper should appear at the end of installed extension icons in top bar. Go to some page where it wasn't working before, reload page and try it.

Thanks

jasperjorna commented 10 years ago

I think it's working correctly now on my retina Macbook!

kepi commented 10 years ago

New version 0.3.4 with this fix just released.

matthijsgroen commented 10 years ago

It works great now thanks!

kepi commented 10 years ago

Nice, thanks for letting me know.