search

kepler155c / opus-apps

Computercraft Applications for Opus OS
MIT License
32 stars 28 forks source link

Try to update Milo for 1.19 #63

Open Kan18 opened 1 year ago

Kan18 commented 1 year ago

Removes Milo trying to access damage on items (nil because of The Flattening). Changes "getItemMeta" to "getItemDetail". We might also need to reimplement showing durability in the item's display name - I got a little too carried away with removing mentions of "damage". Also renames nbtHash to nbt to be consistent with new CC:T naming. I tried not to touch anything related to MiloRemote for now, and there are probably still many bugs remaining that need to be ironed out. Most of the basic functionality works now, though.

Kan18 commented 1 year ago

We might also have to fix all the recipes as well, by removing the damage values

Kan18 commented 1 year ago

Actually, half the recipes are broken because of renamed items; maybe dump them again or something

Kan18 commented 1 year ago

Thanks for the feedback! Sorry I'm getting to this just now. The PR still has weird bugs involving items with NBT, so I am marking this as draft right now. Also, somebody brought up the issue of 1.12.2 compatibility on Discord - not exactly sure how to solve this (having two different branches/versions, maybe?)