Open maartenbreddels opened 4 years ago
Maybe it's an idea to commit package/yarn lock files?
@maartenbreddels few notes:
Thanks Giuseppe,
I see a top level yarn.lock, but does that influence the packages in https://github.com/keplergl/kepler.gl/blob/master/bindings/kepler.gl-jupyter/js/package.json ?
- make sure all kepler.gl peer dependencies are satisfied. I think you may have an old version or redux and/or react-redux
How do I do that?
cheers,
Maarten
@maartenbreddels Can you upgrade to keplergl==0.2.0, it should fix it
I pulled from master, ran git clean
and the whole machinery again, but get the same issues.
try delete node_modules
and yarn.lock
in bindings/kepler.gl-jupyter/js
then run yarn
if still save error, see if your yarn.lock set different version for:
"react": "^16.8.4",
"react-dom": "^16.8.4",
"react-redux": "^7.1.3",
"redux": "^3.7.2",
"redux-actions": "^2.2.1"
"react": "^16.8.4", "react-dom": "^16.8.4", "react-redux": "^7.1.3", "redux": "^3.7.2", "redux-actions": "^2.2.1"
This is what fixed it! I hope that feedback is useful. Do you know the root issue?
yes because we updated dependencies, git clean doesn't cleanup the older version in the node_modeuls, you were still loading the older version of redux
Describe the bug Dev install does not produce a working nbextension, upon creating a widget view, the js dev console gives:
Note that creating the widget works, but looking at the code it seems you only create the kepler object when the view is created:
To Reproduce
display(map_1)
(now the error comes)Expected behavior A clear and concise description of what you expected to happen.
Environment (please complete the following information):