[Feat] Geocoder search options

keplergl / kepler.gl

Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.

http://kepler.gl

MIT License

10.39k stars 1.74k forks source link

[Feat] Geocoder search options #1082

Open b2kdaman opened 4 years ago

b2kdaman commented 4 years ago

Is your feature request related to a problem? Please describe. Geocoder search options can have additional options for user to customize

Describe the solution you'd like I provider the design and will do the code implementation of following features:

Pin color
Map focus option(place coordinates aka point OR bbox aka area)

Describe alternatives you've considered None

UPDATE

Make geocoder layer be removed when geocoder option is turned off
Move geocoder layer to separate mapbox layer as in https://github.com/keplergl/kepler.gl/blob/master/src/components/map-container.js#L354-L366
store geocoder data in interactionConfig

Additional context Figma access can be provided. Design mockup attached Kepler Designsgeocoder

heshan0131 commented 4 years ago

what's the difference between focus map on selected result point and area?

b2kdaman commented 4 years ago

@heshan0131 When result contains bbox it zooms to it's area If not it zooms to center. (lat, lon) Selecting a point option always uses center. For most geographical places that have bbox center is not in the mathematical center of the area. Not in center of bbox in this case.

b2kdaman commented 4 years ago

@macrigiuseppe

heshan0131 commented 4 years ago

Can it be automatic? I feel like it should always search for bbox, and if the result doesn't contain bbox, it should use the center as a fallback. To me the less a user has to manually config, the better.

b2kdaman commented 4 years ago

@heshan0131 It's automatic, but what if user wants to have pin visible, in some cases it's not Maybe it should be 'center on pin' toggle

heshan0131 commented 4 years ago

if the result only contains a bounding box, can we show an actual polygon? or just put a pin in the center?

b2kdaman commented 4 years ago

if the result only contains a bounding box, can we show an actual polygon? or just put a pin in the center?

@heshan0131 right now we are zooming in on bounding box pin center. In most cases pin position is not in the center of bbox if it's provided. Do you wan't me to show rectangle polygon for bbox instead of pin?

b2kdaman commented 4 years ago

Focus on bbox and then pin. Or use existing bbox generation
Color selector stays.
Move geocoder layer to mapbox
Check anchorY property for icon layer in deckgl