search

keplergl / kepler.gl

Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.
http://kepler.gl
MIT License
10.38k stars 1.74k forks source link

[deprecation] viewport-mercator-project was moved to @math.gl/web-mercator #1633

Open chrisgervang opened 3 years ago

chrisgervang commented 3 years ago

When linking packages locally to develop on luma.gl and deck.gl, we've run into an issue where kepler.gl and other libraries don't agree on the version of viewport-mercator-project to use. When researching it I also found on npm that this package is deprecated,

On October 1, 2019 viewport-mercator-project was moved to @math.gl/web-mercator.

kepler.gl is currently pinned to viewport-mercator-project@^6.0.0. The version used by deck.gl 8.2.0 (the version used by kepler) is using "@math.gl/web-mercator": "^3.2.1". I've also found that react-map-gl 5.2.10+ uses viewport-mercator-project@7.0.1. Version 7 is just a re-export of @math.gl/web-mercator.

I'm curious if kepler.gl would accept a PR to replace "viewport-mercator-project": "^6.0.0" with "@math.gl/web-mercator": "^3.2.1", the version used by deck.gl 8.2.0. A search found this package is used in some layers to scale things.

ibgreen commented 3 years ago

We are encouraging apps to move to the math.gl module, so I suspect such a PR would be accepted.

But note that even though the viewport-mercator-project github repo is discontinued, I believe that we have still continued to publish the viewport-mercator-project npm module from math.gl (that now just re-exports the new math.gl module).

@Pessimistress in case I overlooked anything.

Pessimistress commented 3 years ago

There is no reason to pin viewport-mercator-project to v6, which is published from the deprecated repo. v7 is just an alias of @math.gl/web-mercator and will dedupe nicely alongside deck.gl.